Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.1: cluster-ui: update peer dependencies #67981

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

celiala
Copy link
Collaborator

@celiala celiala commented Jul 23, 2021

Backport 1/1 commits from #67722 and #67989.

/cc @cockroachdb/release

Note for reviewers:

  • Blathers check is failing because this hasn't been in master for the "14 day baking duration". This in an internal-facing change, so this feels okay to merge before the baking duration.
  • All other checks pass.

Release justification: Internal-facing only change.

@blathers-crl
Copy link

blathers-crl bot commented Jul 23, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Previously, running yarn for CC console service would output
peer dependency warnings for cluster-ui dependency.

This change updates peer dependencies to remove warnings.

Note: this will also be backported to 21.1 and 20.2, for
respective cluster-ui-21-1 and cluster-ui-20-2 packages.

Release note: None

Co-authored-by: Lauren Barker <[email protected]>
Copy link
Collaborator

@koorosh koorosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@celiala celiala merged commit e351634 into cockroachdb:release-21.1 Jul 27, 2021
@celiala celiala deleted the backport21.1-67722 branch July 27, 2021 22:40
@celiala
Copy link
Collaborator Author

celiala commented Jul 27, 2021

TFTRs!

craig bot pushed a commit that referenced this pull request Jul 27, 2021
67989: cluster-ui: bump package.json version r=celiala a=celiala

In #67722, we updated peerDependencies, but forgot to bump
the version in package.json.

This fast-follow PR bumps the version for #67722.

Note: this has been preemptively backported to 21.1 and 20.2, in #67981 and #67982 respectively.


Release note: None

68088: roachtest: create perf dir for bulk roachtests r=pbardea a=pbardea

When the bulk op roachtests were updated to avoid racing when writing
their stats files, the creation of the perf directory itself was
removed. This adds it back.

There was some consideration to update PutString to create the
filepath.Dir of its destination but that refactor was left for a
potential follow up since it applies to other tests as well.

Fixes #67870.

Release note: None

68118: roachtest: bump import/tpch/nodes=8 timeout to 10h r=tbg,pbardea a=adityamaru

Previously, the roachtest had a timeout of 8h. The test
usually runs in ~7hrs but occasionally tips over the
configured time out. While we investigate the slowness
of this import as tracked in #68117,
we are bumping the timeout to 10h.

Release note: None

68119: rowexec: ask for at least 8MiB in the join reader memory limit r=yuzefovich a=yuzefovich

The join reader doesn't know how to spill to disk, so previously in some
cases (namely, when `distsql_workmem` session variable is low) the
queries would error out. Now this is temporarily fixed by requiring the
memory limit to be at least 8MiB (to accommodate 4MiB scratch input
rows). This shouldn't really matter in the production setting but makes
`tpchvec/disk` roachtest happy.

Fixes: #68036.

Release note: None

Co-authored-by: Celia La <[email protected]>
Co-authored-by: Paul Bardea <[email protected]>
Co-authored-by: Aditya Maru <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants