-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-21.1: cluster-ui: update peer dependencies #67981
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
Previously, running yarn for CC console service would output peer dependency warnings for cluster-ui dependency. This change updates peer dependencies to remove warnings. Note: this will also be backported to 21.1 and 20.2, for respective cluster-ui-21-1 and cluster-ui-20-2 packages. Release note: None Co-authored-by: Lauren Barker <[email protected]>
celiala
force-pushed
the
backport21.1-67722
branch
from
July 23, 2021 16:18
861fb04
to
6860212
Compare
nathanstilwell
approved these changes
Jul 26, 2021
koorosh
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TFTRs! |
craig bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
67989: cluster-ui: bump package.json version r=celiala a=celiala In #67722, we updated peerDependencies, but forgot to bump the version in package.json. This fast-follow PR bumps the version for #67722. Note: this has been preemptively backported to 21.1 and 20.2, in #67981 and #67982 respectively. Release note: None 68088: roachtest: create perf dir for bulk roachtests r=pbardea a=pbardea When the bulk op roachtests were updated to avoid racing when writing their stats files, the creation of the perf directory itself was removed. This adds it back. There was some consideration to update PutString to create the filepath.Dir of its destination but that refactor was left for a potential follow up since it applies to other tests as well. Fixes #67870. Release note: None 68118: roachtest: bump import/tpch/nodes=8 timeout to 10h r=tbg,pbardea a=adityamaru Previously, the roachtest had a timeout of 8h. The test usually runs in ~7hrs but occasionally tips over the configured time out. While we investigate the slowness of this import as tracked in #68117, we are bumping the timeout to 10h. Release note: None 68119: rowexec: ask for at least 8MiB in the join reader memory limit r=yuzefovich a=yuzefovich The join reader doesn't know how to spill to disk, so previously in some cases (namely, when `distsql_workmem` session variable is low) the queries would error out. Now this is temporarily fixed by requiring the memory limit to be at least 8MiB (to accommodate 4MiB scratch input rows). This shouldn't really matter in the production setting but makes `tpchvec/disk` roachtest happy. Fixes: #68036. Release note: None Co-authored-by: Celia La <[email protected]> Co-authored-by: Paul Bardea <[email protected]> Co-authored-by: Aditya Maru <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #67722 and #67989.
/cc @cockroachdb/release
Note for reviewers:
Release justification: Internal-facing only change.